media/formats/mp2t/es_parser_adts.cc - Issue 646673002: Skip audio frames with unknown timestamp in MPEG2TS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp2t/es_parser_adts.cc

Issue 646673002: Skip audio frames with unknown timestamp in MPEG2TS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed also mpeg1 parser and updated unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp2t/es_parser_adts.cc

diff --git a/media/formats/mp2t/es_parser_adts.cc b/media/formats/mp2t/es_parser_adts.cc

index bb9433220cce02dd3838b419eb2674d88e3e8caf..0038b8c9743cf0bd616a29d030006ba20701d052 100644

--- a/media/formats/mp2t/es_parser_adts.cc

+++ b/media/formats/mp2t/es_parser_adts.cc

@@ -140,8 +140,9 @@ bool EsParserAdts::ParseFromEsQueue() {

audio_timestamp_helper_->SetBaseTimestamp(current_timing_desc.pts);

if (audio_timestamp_helper_->base_timestamp() == kNoTimestamp()) {

- DVLOG(1) << "Audio frame with unknown timestamp";

- return false;

+ DVLOG(1) << "Skip audio frame with unknown timestamp";

wolenetz 2014/10/09 19:12:46 nit: s/Skip/Skipping/ :) (and ditto in the mpeg1au

servolk 2014/10/09 20:14:11 Done.

+ SkipAdtsFrame(adts_frame);

+ continue;

}

base::TimeDelta current_pts = audio_timestamp_helper_->GetTimestamp();

base::TimeDelta frame_duration =

« no previous file with comments | « no previous file | media/formats/mp2t/es_parser_adts_unittest.cc » ('j') | no next file with comments »