Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 646543004: Implement :valid and :invalid pseudoclass for <form> (resubmitting) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Stop using willValidate for :valid/:invalid pseudo-classes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/SharedStyleFinder.cpp
diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp
index ce16c0df1f0d4b7ef17a08556a3e785caf1906c7..2e37f8c28edca916ecb29c0898801b01b8aabfca 100644
--- a/Source/core/css/resolver/SharedStyleFinder.cpp
+++ b/Source/core/css/resolver/SharedStyleFinder.cpp
@@ -84,7 +84,7 @@ bool SharedStyleFinder::canShareStyleWithControl(Element& candidate) const
if (willValidate != element().willValidate())
return false;
- if (willValidate && (candidate.isValidFormControlElement() != element().isValidFormControlElement()))
+ if (willValidate && (candidate.isValidElement() != element().isValidElement()))
return false;
if (candidate.isInRange() != element().isInRange())
@@ -265,6 +265,11 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const
return false;
}
+ if (document().containsValidityStyleRules()) {
+ if (candidate.isValidElement() != element().isValidElement())
+ return false;
+ }
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698