Source/core/dom/Element.h - Issue 646543004: Implement :valid and :invalid pseudoclass for <form> (resubmitting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 646543004: Implement :valid and :invalid pseudoclass for <form> (resubmitting) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Stop using willValidate for :valid/:invalid pseudo-classes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index 0b65f3f9a7bfa70bce1305ed37f6caddb9cdb04d..678111499ac23a57d65e6816ece1be216bb68f16 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -429,7 +429,8 @@ public:

virtual bool isRequiredFormControl() const { return false; }

virtual bool isDefaultButtonForForm() const { return false; }

virtual bool willValidate() const { return false; }

- virtual bool isValidFormControlElement() { return false; }

+ virtual bool isValidElement() { return false; }

+ virtual bool matchesValidityPseudoClasses() const { return false; }

keishi 2014/10/15 06:37:16 nit: maybe this should be grouped with matchesRead

Bartek Nowierski 2014/10/15 06:43:05 Done.

virtual bool isInRange() const { return false; }

virtual bool isOutOfRange() const { return false; }

virtual bool isClearButtonElement() const { return false; }

« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | Source/core/html/HTMLFormControlElement.h » ('j') | no next file with comments »