Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 646353002: Give up on threaded animations for the Mac App Launcher NSWindow (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Give up on threaded animations for the Mac App Launcher NSWindow AppKit ignores -[NSView canDrawConcurrently:] and invokes redraws on the animation thread. The last attempt to make one part safe was r296591. However, http://crbug.com/421952 links to undiagnosable crashes within AppKit from a build at r298667. These are likely race conditions due to this threading. The downside is just that, when Chrome is not running, the initial appearance of the app launcher window will be a bit delayed, and will just "pop" in, rather than animate. BUG=421952 Committed: https://crrev.com/7e2712889cc4ca1f62c7305b96a971b50abdf621 Cr-Commit-Position: refs/heads/master@{#299268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +6 lines, -8 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller.mm View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Jack, PTAL
6 years, 2 months ago (2014-10-13 06:25:23 UTC) #2
jackhou1
lgtm
6 years, 2 months ago (2014-10-13 06:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646353002/1
6 years, 2 months ago (2014-10-13 06:33:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 06:59:42 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 07:00:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e2712889cc4ca1f62c7305b96a971b50abdf621
Cr-Commit-Position: refs/heads/master@{#299268}

Powered by Google App Engine
This is Rietveld 408576698