Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac.mm

Issue 646353002: Give up on threaded animations for the Mac App Launcher NSWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/cocoa/apps_search_results_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_service_mac.mm
diff --git a/chrome/browser/ui/app_list/app_list_service_mac.mm b/chrome/browser/ui/app_list/app_list_service_mac.mm
index 06095b12f7e65fe3855b36c18ad8575aef4776fd..0dac38473e13d189cc6a2a0caf4647a3b98ddd97 100644
--- a/chrome/browser/ui/app_list/app_list_service_mac.mm
+++ b/chrome/browser/ui/app_list/app_list_service_mac.mm
@@ -579,14 +579,12 @@ void AppListService::InitAll(Profile* initial_profile) {
[animation_ setAnimationCurve:NSAnimationEaseOut];
window_.reset();
}
- // Threaded animations are buggy on Snow Leopard. See http://crbug.com/335550.
- // Note that in the non-threaded case, the animation won't start unless the
- // UI runloop has spun up, so on <= Lion the animation will only animate if
- // Chrome is already running.
- if (base::mac::IsOSMountainLionOrLater())
- [animation_ setAnimationBlockingMode:NSAnimationNonblockingThreaded];
- else
- [animation_ setAnimationBlockingMode:NSAnimationNonblocking];
+ // This once used a threaded animation, but AppKit would too often ignore
+ // -[NSView canDrawConcurrently:] and just redraw whole view hierarchies on
+ // the animation thread anyway, creating a minefield of race conditions.
+ // Non-threaded means the animation isn't as smooth and doesn't begin unless
+ // the UI runloop has spun up (after profile loading).
+ [animation_ setAnimationBlockingMode:NSAnimationNonblocking];
[animation_ startAnimation];
}
« no previous file with comments | « no previous file | ui/app_list/cocoa/apps_search_results_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698