Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 64633003: Fix error message when using exclusion (Closed)

Created:
7 years, 1 month ago by sdefresne
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix error message when using exclusion When using "variable!" syntax to remove a value, if "variable" is not a list, display the type of "variable", not the type of the value passed to "variable!". Patch by Sylvain Defresne <sdefresne@chromium.org>;

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pylib/gyp/input.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sdefresne
This fix the message in the assertion (otherwise you get "chrome key xcode_settings must be ...
7 years, 1 month ago (2013-11-08 09:54:52 UTC) #1
Mark Mentovai
LGTM
7 years, 1 month ago (2013-11-08 14:17:09 UTC) #2
sdefresne
On 2013/11/08 14:17:09, Mark Mentovai wrote: > LGTM I don't have committer access. Can you ...
7 years, 1 month ago (2013-11-12 09:11:42 UTC) #3
Mark Mentovai
7 years, 1 month ago (2013-11-15 16:41:46 UTC) #4
Committed r1786.

Powered by Google App Engine
This is Rietveld 408576698