Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 646283004: Don't use PLY cache files in Tools/Scripts/run-bindings-tests (Closed)

Created:
6 years, 2 months ago by Jens Widell
Modified:
6 years, 2 months ago
Reviewers:
haraken, yhirano
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't use PLY cache files in Tools/Scripts/run-bindings-tests We don't need the caching, and disabling it avoids cache coherency issues as well as leaving untracked files in the tree. BUG=426339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M Source/bindings/scripts/blink_idl_lexer.py View 2 chunks +5 lines, -1 line 0 comments Download
M Source/bindings/scripts/idl_compiler.py View 2 chunks +1 line, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL
6 years, 2 months ago (2014-10-23 08:19:30 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-23 08:21:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646283004/1
6 years, 2 months ago (2014-10-23 08:28:26 UTC) #5
yhirano
lgtm. Thanks!
6 years, 2 months ago (2014-10-23 09:00:59 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 09:30:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184249

Powered by Google App Engine
This is Rietveld 408576698