Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 646283004: Don't use PLY cache files in Tools/Scripts/run-bindings-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/idl_compiler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index cbc38cec11b87888433ed96f0fec7ffba37ab242..0b53f764ce65d8bc635490cb727e548d74f4a922 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -80,12 +80,6 @@ COMPONENT_DIRECTORY = frozenset(['core', 'modules'])
test_input_directory = os.path.join(source_path, 'bindings', 'tests', 'idls')
reference_directory = os.path.join(source_path, 'bindings', 'tests', 'results')
-PLY_LEX_YACC_FILES = frozenset([
- 'lextab.py', # PLY lex
- 'lextab.pyc',
- 'parsetab.pickle', # PLY yacc
-])
-
@contextmanager
def TemporaryDirectory():
"""Wrapper for tempfile.mkdtemp() so it's usable with 'with' statement.
@@ -140,7 +134,7 @@ def generate_interface_dependencies(output_directory):
# In order to allow test IDL files to override the production IDL files if
# they have the same interface name, process the test IDL files after the
# non-test IDL files.
- reader = IdlReader(outputdir=output_directory)
+ reader = IdlReader()
for idl_path_list in (non_test_idl_paths, test_idl_paths):
for idl_path in idl_path_list:
if os.path.basename(idl_path) in NON_BLINK_IDL_FILES:
@@ -183,11 +177,7 @@ def bindings_tests(output_directory, verbose):
return executive.run_command(cmd, error_handler=lambda x: None)
def is_cache_file(filename):
- if filename in PLY_LEX_YACC_FILES:
- return True
- if filename.endswith('.cache'): # Jinja
- return True
- return False
+ return filename.endswith('.cache')
def delete_cache_files():
# FIXME: Instead of deleting cache files, don't generate them.
« no previous file with comments | « Source/bindings/scripts/idl_compiler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698