Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: sky/engine/core/editing/EditorCommand.cpp

Issue 646273006: Get rid of ScrollView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: merge to ToT Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/editing/EditorCommand.cpp
diff --git a/sky/engine/core/editing/EditorCommand.cpp b/sky/engine/core/editing/EditorCommand.cpp
index 7e357337bde076b20cd55b96a0fb9d33ba36f0f3..802b8486fdadfd5dde15503da0c8186d2a7682f4 100644
--- a/sky/engine/core/editing/EditorCommand.cpp
+++ b/sky/engine/core/editing/EditorCommand.cpp
@@ -104,7 +104,8 @@ static unsigned verticalScrollDistance(LocalFrame& frame)
return 0;
if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO || focusedElement->hasEditableStyle()))
return 0;
- int height = std::min<int>(renderBox.clientHeight(), frame.view()->visibleHeight());
+ int height = std::min<int>(renderBox.clientHeight(),
+ frame.view()->height());
return static_cast<unsigned>(max(max<int>(height * ScrollableArea::minFractionToStepWhenPaging(), height - ScrollableArea::maxOverlapBetweenPages()), 1));
}

Powered by Google App Engine
This is Rietveld 408576698