tools/render_pictures_main.cpp - Issue 646213002: Eliminate one copy of replace_char() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/render_pictures_main.cpp

Issue 646213002: Eliminate one copy of replace_char() function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add another test with some weird characters Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/render_pictures_main.cpp

diff --git a/tools/render_pictures_main.cpp b/tools/render_pictures_main.cpp

index 6faa81ac0eec75aa502fe48627ea3266b0294c15..38603c93f487a60f11d2ceae9c852764a13d3002 100644

--- a/tools/render_pictures_main.cpp

+++ b/tools/render_pictures_main.cpp

@@ -354,7 +354,7 @@ static bool render_picture(const SkString& inputPath, const SkString* writePath,

SkString inputFilename = SkOSPath::Basename(inputPath.c_str());

SkString outputFilename(inputFilename);

- sk_tools::replace_char(&outputFilename, '.', '_');

+ outputFilename.replace('.', '_');

outputFilename.append(".png");

if (jsonSummaryPtr) {