Eliminate one copy of replace_char() function.

tests/StringTest.cpp

Index: tests/StringTest.cpp
diff --git a/tests/StringTest.cpp b/tests/StringTest.cpp
index 13ee5ec2153ff6da775bef64887fc16f759da2f4..4df421bce33ec95a574656140b7643084d1f2bc2 100644
--- a/tests/StringTest.cpp
+++ b/tests/StringTest.cpp
@@ -184,6 +184,20 @@ DEF_TEST(String, reporter) {
     REPORTER_ASSERT(reporter, buffer[19] == 0);
     REPORTER_ASSERT(reporter, buffer[20] == 'a');
 
+    SkString skia_2d("skia_2d");
+    SkString skia2d("skia-2d");
+    skia_2d.replace('_', '-');
+    REPORTER_ASSERT(reporter, skia_2d == skia2d);
+
+    SkString meat("meat");
+    SkString meet("meet");
+    meat.replace('a', 'e');
+    REPORTER_ASSERT(reporter, meat == meet);
+
+    SkString hangul("\xed\x95\x9c\xea\xb5\xad\xec\x96\xb4");

[tfarina, 2014/10/18 03:42:27]

Mike, could you take another look? Let me know if this is OK.

+    SkString hangul2("\xb4\x95\x9c\xea\xb5\xad\xec\x96\xb4");
+    hangul.replace('\xed', '\xb4');
+    REPORTER_ASSERT(reporter, hangul == hangul2);
 }
 
 DEF_TEST(String_SkStrSplit, r) {