tools/PictureRenderer.cpp - Issue 646213002: Eliminate one copy of replace_char() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/PictureRenderer.cpp

Issue 646213002: Eliminate one copy of replace_char() function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add another test with some weird characters Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/PictureRenderer.cpp

diff --git a/tools/PictureRenderer.cpp b/tools/PictureRenderer.cpp

index b9b01e4cf96093c64306395cd3342496803068e9..e6f92aaee127a4532175694f62662f209c0d0a1e 100644

--- a/tools/PictureRenderer.cpp

+++ b/tools/PictureRenderer.cpp

@@ -296,7 +296,7 @@ static bool write(SkCanvas* canvas, const SkString& writePath, const SkString& m

BitmapAndDigest bitmapAndDigest(bitmap);

SkString escapedInputFilename(inputFilename);

- replace_char(&escapedInputFilename, '.', '_');

+ escapedInputFilename.replace('.', '_');

// TODO(epoger): what about including the config type within outputFilename? That way,

// we could combine results of different config types without conflicting filenames.