Eliminate one copy of replace_char() function.

tools/picture_utils.h

Index: tools/picture_utils.h
diff --git a/tools/picture_utils.h b/tools/picture_utils.h
index a5fcf7c96898cdcc178849025d2d98a4f5481639..14f48653050a50675125faf7da610fa87ba7447d 100644
--- a/tools/picture_utils.h
+++ b/tools/picture_utils.h
@@ -23,9 +23,8 @@ namespace sk_tools {
     /**
      * Replaces all instances of oldChar with newChar in str.
      *
-     * TODO: This function appears here and in skimage_main.cpp ;
-     * we should add the implementation to src/core/SkString.cpp, write tests for it,
-     * and remove it from elsewhere.
+     * TODO: We should add the implementation to src/core/SkString.cpp, write
+     * tests for it.
      */
     void replace_char(SkString* str, const char oldChar, const char newChar);

[reed1, 2014/10/15 14:13:07]

Hey, this looks semantically dangerous. SkString is UTF8 encoded, so we can't
safely replace (e.g. 0x85) with (e.g. 0x6F). I suggest if we want a "replace"
function, it should operate on SkUnichar types.