Eliminate one copy of replace_char() function.

tools/picture_utils.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef picture_utils_DEFINED
 #define picture_utils_DEFINED
 
 class SkBitmap;
 class SkString;
 
 namespace sk_tools {
     // since PNG insists on unpremultiplying our alpha, we take no precision
     // chances and force all pixels to be 100% opaque, otherwise on compare we
     // may not get a perfect match.
     //
     // This expects a bitmap with a config type of 8888 and for the pixels to
     // not be on the GPU.
     void force_all_opaque(const SkBitmap& bitmap);
 
     /**
      * Replaces all instances of oldChar with newChar in str.
      *
-     * TODO: This function appears here and in skimage_main.cpp ;
-     * we should add the implementation to src/core/SkString.cpp, write tests for it,
-     * and remove it from elsewhere.
+     * TODO: We should add the implementation to src/core/SkString.cpp, write
+     * tests for it.
      */
     void replace_char(SkString* str, const char oldChar, const char newChar);

[reed1, 2014/10/15 14:13:07]

Hey, this looks semantically dangerous. SkString is UTF8 encoded, so we can't
safely replace (e.g. 0x85) with (e.g. 0x6F). I suggest if we want a "replace"
function, it should operate on SkUnichar types.

 
     // Returns true if the string ends with %
     bool is_percentage(const char* const string);
 
     // Prepares the bitmap so that it can be written.
     //
     // Specifically, it configures the bitmap, allocates pixels and then
     // erases the pixels to transparent black.
     void setup_bitmap(SkBitmap* bitmap, int width, int height);
 
     /**
      * Write a bitmap file to disk.
      *
      * @param bm the bitmap to record
      * @param dirPath directory within which to write the image file
      * @param subdirOrNull subdirectory within dirPath, or NULL to just write into dirPath
      * @param baseName last part of the filename
      *
      * @return true if written out successfully
      */
     bool write_bitmap_to_disk(const SkBitmap& bm, const SkString& dirPath,
                               const char *subdirOrNull, const SkString& baseName);
 
 } // namespace sk_tools
 
 #endif  // picture_utils_DEFINED