Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/page/actions/seek_unittest.py

Issue 646063002: [Telemetry] Chose some slightly more reasonable timeouts for actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/actions/play_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/seek_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/seek_unittest.py b/tools/telemetry/telemetry/page/actions/seek_unittest.py
index e2b8eea031a698550cb6eaaf1d431054bacf652b..108f56e5edbb6d4cb936bef51e56cd69be1f9ef5 100644
--- a/tools/telemetry/telemetry/page/actions/seek_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/seek_unittest.py
@@ -18,7 +18,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
def testSeekWithNoSelector(self):
"""Tests that with no selector Seek action seeks first media element."""
- action = seek.SeekAction(seconds=1, timeout_in_seconds=10)
+ action = seek.SeekAction(seconds=1, timeout_in_seconds=5)
action.WillRunAction(self._tab)
action.RunAction(self._tab)
# Assert only first video has played.
@@ -28,7 +28,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
def testSeekWithVideoSelector(self):
"""Tests that Seek action seeks video element matching selector."""
action = seek.SeekAction(seconds=1, selector='#video_1',
- timeout_in_seconds=10)
+ timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
@@ -41,7 +41,7 @@ class SeekActionTest(tab_test_case.TabTestCase):
def testSeekWithAllSelector(self):
"""Tests that Seek action seeks all video elements with selector='all'."""
action = seek.SeekAction(seconds=1, selector='all',
- timeout_in_seconds=10)
+ timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
« no previous file with comments | « tools/telemetry/telemetry/page/actions/play_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698