Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/telemetry/telemetry/page/actions/play_unittest.py

Issue 646063002: [Telemetry] Chose some slightly more reasonable timeouts for actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/play_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/play_unittest.py b/tools/telemetry/telemetry/page/actions/play_unittest.py
index e36b4e7a7a0097b846c08bfc9944b86a529497f5..b0f43f15d3179b7ee7d40965359a388609fe4db8 100644
--- a/tools/telemetry/telemetry/page/actions/play_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/play_unittest.py
@@ -21,7 +21,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
@decorators.Disabled('android')
def testPlayWithNoSelector(self):
"""Tests that with no selector Play action plays first video element."""
- action = play.PlayAction(playing_event_timeout_in_seconds=60)
+ action = play.PlayAction(playing_event_timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
@@ -35,7 +35,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWithVideoSelector(self):
"""Tests that Play action plays video element matching selector."""
action = play.PlayAction(selector='#video_1',
- playing_event_timeout_in_seconds=60)
+ playing_event_timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
@@ -49,7 +49,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWithAllSelector(self):
"""Tests that Play action plays all video elements with selector='all'."""
action = play.PlayAction(selector='all',
- playing_event_timeout_in_seconds=60)
+ playing_event_timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
@@ -63,7 +63,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWaitForPlayTimeout(self):
"""Tests that wait_for_playing timeouts if video does not play."""
action = play.PlayAction(selector='#video_1',
- playing_event_timeout_in_seconds=0.1)
+ playing_event_timeout_in_seconds=5)
action.WillRunAction(self._tab)
self._tab.EvaluateJavaScript('document.getElementById("video_1").src = ""')
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
@@ -73,7 +73,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
def testPlayWaitForEnded(self):
"""Tests that wait_for_ended waits for video to end."""
action = play.PlayAction(selector='#video_1',
- ended_event_timeout_in_seconds=60)
+ ended_event_timeout_in_seconds=5)
action.WillRunAction(self._tab)
# Assert video not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
« no previous file with comments | « tools/telemetry/telemetry/page/actions/loop_unittest.py ('k') | tools/telemetry/telemetry/page/actions/seek_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698