Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: cc/resources/resource_provider.h

Issue 645943002: cc: Move GpuMemoryBuffer allocation to worker threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chromium-image-refactor
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_provider.h
diff --git a/cc/resources/resource_provider.h b/cc/resources/resource_provider.h
index dc8e7b6cacada7f462c89cc7ee81ec7f215def4c..bd79cc4f8234c1309f04c1ad22d7e7da1230e24f 100644
--- a/cc/resources/resource_provider.h
+++ b/cc/resources/resource_provider.h
@@ -312,11 +312,13 @@ class CC_EXPORT ResourceProvider {
ResourceProvider::ResourceId resource_id);
~ScopedWriteLockGpuMemoryBuffer();
- gfx::GpuMemoryBuffer* gpu_memory_buffer() { return gpu_memory_buffer_; }
+ gfx::GpuMemoryBuffer* GetGpuMemoryBuffer();
private:
ResourceProvider* resource_provider_;
ResourceProvider::ResourceId resource_id_;
+ gfx::Size size_;
+ ResourceFormat format_;
gfx::GpuMemoryBuffer* gpu_memory_buffer_;
DISALLOW_COPY_AND_ASSIGN(ScopedWriteLockGpuMemoryBuffer);
@@ -328,12 +330,12 @@ class CC_EXPORT ResourceProvider {
ResourceProvider::ResourceId resource_id);
~ScopedWriteLockGr();
- SkSurface* sk_surface() { return sk_surface_; }
+ SkSurface* sk_surface() { return sk_surface_.get(); }
private:
ResourceProvider* resource_provider_;
ResourceProvider::ResourceId resource_id_;
- SkSurface* sk_surface_;
+ skia::RefPtr<SkSurface> sk_surface_;
DISALLOW_COPY_AND_ASSIGN(ScopedWriteLockGr);
};
@@ -496,12 +498,8 @@ class CC_EXPORT ResourceProvider {
Resource* GetResource(ResourceId id);
const Resource* LockForRead(ResourceId id);
void UnlockForRead(ResourceId id);
- const Resource* LockForWrite(ResourceId id);
- void UnlockForWrite(ResourceId id);
- const Resource* LockForWriteToGpuMemoryBuffer(ResourceId id);
- void UnlockForWriteToGpuMemoryBuffer(ResourceId id);
- const Resource* LockForWriteToSkSurface(ResourceId id);
- void UnlockForWriteToSkSurface(ResourceId id);
+ Resource* LockForWrite(ResourceId id);
+ Resource* UnlockForWrite(ResourceId id);
static void PopulateSkBitmapWithResource(SkBitmap* sk_bitmap,
const Resource* resource);

Powered by Google App Engine
This is Rietveld 408576698