Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: gin/public/v8_platform.h

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/per_context_data.h ('k') | gin/run_microtasks_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/v8_platform.h
diff --git a/gin/public/v8_platform.h b/gin/public/v8_platform.h
index 59e21479f53d12c49d892868b6f8d7334768c08d..a4fc28a9bc32cf394af4027cddfc116a85219fd1 100644
--- a/gin/public/v8_platform.h
+++ b/gin/public/v8_platform.h
@@ -19,17 +19,17 @@ class GIN_EXPORT V8Platform : public NON_EXPORTED_BASE(v8::Platform) {
static V8Platform* Get();
// v8::Platform implementation.
- virtual void CallOnBackgroundThread(
+ void CallOnBackgroundThread(
v8::Task* task,
v8::Platform::ExpectedRuntime expected_runtime) override;
- virtual void CallOnForegroundThread(v8::Isolate* isolate,
- v8::Task* task) override;
- virtual double MonotonicallyIncreasingTime() override;
+ void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override;
+ double MonotonicallyIncreasingTime() override;
+
private:
friend struct base::DefaultLazyInstanceTraits<V8Platform>;
V8Platform();
- virtual ~V8Platform();
+ ~V8Platform() override;
DISALLOW_COPY_AND_ASSIGN(V8Platform);
};
« no previous file with comments | « gin/per_context_data.h ('k') | gin/run_microtasks_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698