Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 645803002: OOPIF: Fix CapturePageInfo to only operate on local main frames. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
Reviewers:
alexmos, sky
CC:
chromium-reviews, site-isolation-reviews_chromium.org, nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Fix CapturePageInfo to only operate on local main frames. This logic will need to move to the browser process to capture text from frames that live in other processes. BUG=346764 TEST=Navigate in an out-of-process iframe and wait 10 seconds. Committed: https://crrev.com/ec6b51a9acf58ca21219c28a51e85d98f6f873dd Cr-Commit-Position: refs/heads/master@{#299138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Charlie Reis
Nasko: This gets us past the page info crash, since it's trying to walk the ...
6 years, 2 months ago (2014-10-10 16:04:55 UTC) #2
Charlie Reis
Alex, can you review since Nasko is out today?
6 years, 2 months ago (2014-10-10 17:40:32 UTC) #4
alexmos
LGTM
6 years, 2 months ago (2014-10-10 17:42:33 UTC) #5
Charlie Reis
[+sky] Thanks! Scott, can you take a look for chrome/ owner's approval? This gets link ...
6 years, 2 months ago (2014-10-10 17:45:38 UTC) #7
sky
LGTM
6 years, 2 months ago (2014-10-10 17:59:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645803002/1
6 years, 2 months ago (2014-10-10 18:05:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 18:17:11 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:18:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec6b51a9acf58ca21219c28a51e85d98f6f873dd
Cr-Commit-Position: refs/heads/master@{#299138}

Powered by Google App Engine
This is Rietveld 408576698