Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5319)

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 645803002: OOPIF: Fix CapturePageInfo to only operate on local main frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index 38aaae9fbb70583ca9fc41b2bd51fcc6db151df0..a2e1b9aecc961cc413ebc94187a186cdd02103b8 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -381,6 +381,13 @@ void ChromeRenderViewObserver::CapturePageInfo(bool preliminary_capture) {
if (!main_frame)
return;
+ // TODO(creis): Refactor WebFrame::contentAsText to handle RemoteFrames,
+ // likely by moving it to the browser process. For now, only capture page
+ // info from main frames that are LocalFrames, and ignore their RemoteFrame
+ // children.
+ if (main_frame->isWebRemoteFrame())
+ return;
+
// Don't index/capture pages that are in view source mode.
if (main_frame->isViewSourceModeEnabled())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698