[CSS Grid Layout] ASSERTION FAILED: repetitions > 0

Source/core/css/parser/CSSPropertyParser.cpp

Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index b2ce03f94f44094b1b6cff863858474c8d3e6b54..7281034a3f111d71897c4e6ebff8147a69cfae9a 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -3579,8 +3579,8 @@ bool CSSPropertyParser::parseGridTrackRepeatFunction(CSSValueList& list)
     if (!arguments || arguments->size() < 3 || !validUnit(arguments->valueAt(0), FPositiveInteger) || !isComma(arguments->valueAt(1)))
         return false;
 
-    size_t repetitions = arguments->valueAt(0)->fValue;
-    ASSERT_WITH_SECURITY_IMPLICATION(repetitions > 0);
+    ASSERT_WITH_SECURITY_IMPLICATION(arguments->valueAt(0)->fValue > 0);

[Julien - ping for review, 2014/10/21 15:33:12]

I don't have this ASSERT on my tree.

[svillar, 2014/10/21 15:48:49]

You should, I've just checked current master and it's there. Note that I'm
changing here repetitions by arguments->valueAt(0)->fValue in order to directly
use the parsed value.

[Julien - ping for review, 2014/10/21 19:22:36]

Sigh, I was looking at the wrong place.

+    size_t repetitions = std::min<double>(arguments->valueAt(0)->fValue, kGridMaxTracks);

[Julien - ping for review, 2014/10/21 15:33:12]

Why don't we just use clampTo<size_t>(argument->valueAt(0)->fValue, 0,
kGridMaxTracks)?

[svillar, 2014/10/21 15:48:49]

You're totally right. Let's do it.

 
     RefPtrWillBeRawPtr<CSSValueList> repeatedValues = CSSValueList::createSpaceSeparated();
     arguments->next(); // Skip the repetition count.