[CSS Grid Layout] ASSERTION FAILED: repetitions > 0

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 3561 matching lines @@
 
     return values;
 }
 
 bool CSSPropertyParser::parseGridTrackRepeatFunction(CSSValueList& list)
 {
     CSSParserValueList* arguments = m_valueList->current()->function->args.get();
     if (!arguments || arguments->size() < 3 || !validUnit(arguments->valueAt(0), FPositiveInteger) || !isComma(arguments->valueAt(1)))
         return false;
 
-    size_t repetitions = arguments->valueAt(0)->fValue;
-    ASSERT_WITH_SECURITY_IMPLICATION(repetitions > 0);
+    ASSERT_WITH_SECURITY_IMPLICATION(arguments->valueAt(0)->fValue > 0);

[Julien - ping for review, 2014/10/21 15:33:12]

I don't have this ASSERT on my tree.

[svillar, 2014/10/21 15:48:49]

You should, I've just checked current master and it's there. Note that I'm
changing here repetitions by arguments->valueAt(0)->fValue in order to directly
use the parsed value.

[Julien - ping for review, 2014/10/21 19:22:36]

Sigh, I was looking at the wrong place.

+    size_t repetitions = std::min<double>(arguments->valueAt(0)->fValue, kGridMaxTracks);

[Julien - ping for review, 2014/10/21 15:33:12]

Why don't we just use clampTo<size_t>(argument->valueAt(0)->fValue, 0,
kGridMaxTracks)?

[svillar, 2014/10/21 15:48:49]

You're totally right. Let's do it.

 
     RefPtrWillBeRawPtr<CSSValueList> repeatedValues = CSSValueList::createSpaceSeparated();
     arguments->next(); // Skip the repetition count.
     arguments->next(); // Skip the comma.
 
     // Handle leading <ident>*.
     CSSParserValue* currentValue = arguments->current();
     if (currentValue && currentValue->unit == CSSParserValue::ValueList)
         parseGridLineNames(*arguments, *repeatedValues);
 
@@ skipping 4754 matching lines @@
             return nullptr;
         a = args->next();
 
         argNumber++;
     }
 
     return transformValue.release();
 }
 
 } // namespace blink