Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth. (Closed)

Created:
6 years, 2 months ago by ernstm
Modified:
6 years, 2 months ago
Reviewers:
nednguyen, tonyg, qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

telemetry: Replace mostly_smooth by percentage_smooth. R=tonyg@chromium.org,qyearsley@chromium.org,nednguyen@chromium.org BUG=422093 Committed: https://crrev.com/4db467daa7be87ab05a7c2d6462ca9b87b537a2f Cr-Commit-Position: refs/heads/master@{#299189}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix unit test. Lower threshold to 17ms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M tools/perf/measurements/repaint_unittest.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +8 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 3 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
ernstm
PTAL
6 years, 2 months ago (2014-10-09 22:47:14 UTC) #2
tonyg
lgtm
6 years, 2 months ago (2014-10-09 23:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645753002/1
6 years, 2 months ago (2014-10-09 23:05:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/24418)
6 years, 2 months ago (2014-10-10 01:17:19 UTC) #7
nednguyen
On 2014/10/10 01:17:19, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-10 02:34:52 UTC) #8
qyearsley
lgtm https://codereview.chromium.org/645753002/diff/1/tools/telemetry/telemetry/web_perf/metrics/smoothness.py File tools/telemetry/telemetry/web_perf/metrics/smoothness.py (right): https://codereview.chromium.org/645753002/diff/1/tools/telemetry/telemetry/web_perf/metrics/smoothness.py#newcode150 tools/telemetry/telemetry/web_perf/metrics/smoothness.py:150: frames that were hitting 60 fps. Since smooth_threshold ...
6 years, 2 months ago (2014-10-10 04:02:21 UTC) #9
ernstm
https://codereview.chromium.org/645753002/diff/1/tools/telemetry/telemetry/web_perf/metrics/smoothness.py File tools/telemetry/telemetry/web_perf/metrics/smoothness.py (right): https://codereview.chromium.org/645753002/diff/1/tools/telemetry/telemetry/web_perf/metrics/smoothness.py#newcode150 tools/telemetry/telemetry/web_perf/metrics/smoothness.py:150: frames that were hitting 60 fps. On 2014/10/10 04:02:21, ...
6 years, 2 months ago (2014-10-10 20:13:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645753002/320001
6 years, 2 months ago (2014-10-10 20:14:09 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:320001)
6 years, 2 months ago (2014-10-10 21:32:29 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:33:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4db467daa7be87ab05a7c2d6462ca9b87b537a2f
Cr-Commit-Position: refs/heads/master@{#299189}

Powered by Google App Engine
This is Rietveld 408576698