Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test. Lower threshold to 17ms. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/smoothness_unittest.py
diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py
index 534abad8fd68499d8a151422d5aa5632832beb0e..54b5d0a954be2920f714b3a19d68334f3fc3e314 100644
--- a/tools/perf/measurements/smoothness_unittest.py
+++ b/tools/perf/measurements/smoothness_unittest.py
@@ -116,9 +116,10 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
self.assertEquals(len(jank), 1)
self.assertGreater(jank[0].GetRepresentativeNumber(), 0)
- mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')
- self.assertEquals(len(mostly_smooth), 1)
- self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)
+ percentage_smooth = results.FindAllPageSpecificValuesNamed(
+ 'percentage_smooth')
+ self.assertEquals(len(percentage_smooth), 1)
+ self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)
mean_input_event_latency = results.FindAllPageSpecificValuesNamed(
'mean_input_event_latency')
@@ -136,9 +137,10 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
results = self.RunMeasurement(measurement, ps, options=self._options)
self.assertEquals(0, len(results.failures))
- mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')
- self.assertEquals(len(mostly_smooth), 1)
- self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)
+ percentage_smooth = results.FindAllPageSpecificValuesNamed(
+ 'percentage_smooth')
+ self.assertEquals(len(percentage_smooth), 1)
+ self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)
def testCleanUpTrace(self):
self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
« no previous file with comments | « tools/perf/measurements/repaint_unittest.py ('k') | tools/telemetry/telemetry/web_perf/metrics/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698