Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: Source/core/inspector/ConsoleMessageStorage.h

Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/ConsoleMessageStorage.h
diff --git a/Source/core/inspector/ConsoleMessageStorage.h b/Source/core/inspector/ConsoleMessageStorage.h
index b73dea2587a789849a7d28c309f540702d07dbb4..ec8888ec5d8f2511e0ab9368954d44fb1a3fdf81 100644
--- a/Source/core/inspector/ConsoleMessageStorage.h
+++ b/Source/core/inspector/ConsoleMessageStorage.h
@@ -11,6 +11,7 @@
namespace blink {
+class FrameHost;
class LocalDOMWindow;
class WorkerGlobalScopeProxy;
@@ -23,9 +24,9 @@ public:
return adoptPtrWillBeNoop(new ConsoleMessageStorage(context));
}
- static PassOwnPtrWillBeRawPtr<ConsoleMessageStorage> createForFrame(LocalFrame* frame)
+ static PassOwnPtrWillBeRawPtr<ConsoleMessageStorage> createForFrameHost(FrameHost* frameHost)
{
- return adoptPtrWillBeNoop(new ConsoleMessageStorage(frame));
+ return adoptPtrWillBeNoop(new ConsoleMessageStorage(frameHost));
}
void reportMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
@@ -45,14 +46,12 @@ public:
private:
explicit ConsoleMessageStorage(ExecutionContext*);
- explicit ConsoleMessageStorage(LocalFrame*);
-
- ExecutionContext* executionContext() const;
+ explicit ConsoleMessageStorage(FrameHost*);
int m_expiredCount;
WillBeHeapDeque<RefPtrWillBeMember<ConsoleMessage> > m_messages;
RawPtrWillBeMember<ExecutionContext> m_context;
- RawPtrWillBeMember<LocalFrame> m_frame;
+ RawPtrWillBeMember<FrameHost> m_frameHost;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698