Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 645643004: mac: Fix a logic error in presentation_mode_controller. (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix a logic error in presentation_mode_controller. The method -shouldShowMenubarInImmersiveFullscreen failed to take into consideration whether the screen containing the window had a menu bar. BUG=NONE TEST=On OSX 10.9 or OSX 10.10, set the screensHaveSeparateSpaces setting to NO. On a second monitor, fullscreen a youtube video. Move the mouse to the top of screen. The tabstrip should appear, and should not have extra space for a menu bar. Prior to this CL, there would be extra space for a non-existent menu bar. Committed: https://crrev.com/c1207e6e5804b054f31fc6d7b219caf9943c8e09 Cr-Commit-Position: refs/heads/master@{#299011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
rsesek: Please review.
6 years, 2 months ago (2014-10-09 22:05:18 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-09 22:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645643004/1
6 years, 2 months ago (2014-10-09 23:00:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 23:55:00 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 23:55:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1207e6e5804b054f31fc6d7b219caf9943c8e09
Cr-Commit-Position: refs/heads/master@{#299011}

Powered by Google App Engine
This is Rietveld 408576698