Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9425)

Unified Diff: chrome/browser/ui/cocoa/presentation_mode_controller.mm

Issue 645643004: mac: Fix a logic error in presentation_mode_controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/presentation_mode_controller.mm
diff --git a/chrome/browser/ui/cocoa/presentation_mode_controller.mm b/chrome/browser/ui/cocoa/presentation_mode_controller.mm
index d92fb7b6ad87b15d77c40693081c97a4989c9b76..a80ceb1d40c38bf5dca654caeebe7c983080ec3c 100644
--- a/chrome/browser/ui/cocoa/presentation_mode_controller.mm
+++ b/chrome/browser/ui/cocoa/presentation_mode_controller.mm
@@ -180,8 +180,8 @@ OSStatus MenuBarRevealHandler(EventHandlerCallRef handler,
- (void)showActiveWindowUI;
- (void)hideActiveWindowUI;
-// In Immersive Fullscreen, the menubar is visible iff. toolbarFraction_ >=
-// 1.0.
+// Whether the menu bar should be shown in immersive fullscreen for the screen
+// that contains the window.
- (BOOL)shouldShowMenubarInImmersiveFullscreen;
@end
@@ -745,7 +745,7 @@ OSStatus MenuBarRevealHandler(EventHandlerCallRef handler,
}
- (BOOL)shouldShowMenubarInImmersiveFullscreen {
- return toolbarFraction_ >= 1.0;
+ return [self doesScreenHaveMenuBar] && toolbarFraction_ > 0.99;
}
@end
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698