Source/web/tests/WebFrameTest.cpp - Issue 645623004: Reland "Streamline frame detach"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 645623004: Reland "Streamline frame detach" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move frame count inc/dec to WebFrame append/removeChild Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 2b0965ea90adf4a8d217361aa30c9f75d9ffc256..becab2996022fcee87ebe2fb2052edd73db05797 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -3779,9 +3779,7 @@ TEST_F(WebFrameTest, FindDetachFrameWhileScopingStrings)

EXPECT_FALSE(client.findResultsAreReady());

mainFrame->resetMatchCount();

- for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))

- frame->scopeStringMatches(kFindIdentifier, searchText, options, true);

+ mainFrame->scopeStringMatches(kFindIdentifier, searchText, options, true);

dcheng 2014/10/14 21:43:37 Hmm. Is this change needed to fix a test? Or just

Nate Chapin 2014/10/14 21:45:07 That was a long time ago, and I don't remember. :)

// The first scopeStringMatches will have reset the state. Detach before it actually scopes.

EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());

« no previous file with comments | « Source/web/WebFrame.cpp ('k') | no next file » | no next file with comments »