Source/web/WebFrame.cpp - Issue 645623004: Reland "Streamline frame detach" - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1006)

My Issues | Starred Open | Closed | All

Unified Diff: Source/web/WebFrame.cpp

Issue 645623004: Reland "Streamline frame detach" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move frame count inc/dec to WebFrame append/removeChild Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/web/RemoteFrameClientImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebFrame.cpp

diff --git a/Source/web/WebFrame.cpp b/Source/web/WebFrame.cpp

index c11f2e11122518e8ec0030f07e42c33a4bc5db89..d5498208d7dba748d3c4232433bc605c5315dd42 100644

--- a/Source/web/WebFrame.cpp

+++ b/Source/web/WebFrame.cpp

@@ -5,6 +5,7 @@

#include "config.h"

#include "public/web/WebFrame.h"

+#include "core/frame/FrameHost.h"

#include "core/frame/RemoteFrame.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "platform/UserGestureIndicator.h"

@@ -122,6 +123,7 @@ void WebFrame::appendChild(WebFrame* child)

}

toCoreFrame(this)->tree().invalidateScopedChildCount();

+ toCoreFrame(this)->host()->incrementSubframeCount();

}

void WebFrame::removeChild(WebFrame* child)

@@ -141,6 +143,7 @@ void WebFrame::removeChild(WebFrame* child)

child->m_previousSibling = child->m_nextSibling = 0;

toCoreFrame(this)->tree().invalidateScopedChildCount();

+ toCoreFrame(this)->host()->decrementSubframeCount();

}

WebFrame* WebFrame::parent() const

« no previous file with comments | « Source/web/RemoteFrameClientImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698