Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 645613002: [WebGL-chromium] Return meaningful information in WebGL context creation error message (Closed)

Created:
6 years, 2 months ago by sivag
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebGL] Return meaningful information in WebGL context creation error message. For example, vendor, renderer, driver version, etc.This way a developer can gather data on what platforms the app fails to run. This needs changes on both blink and chromium. Below steps are followed to implement this 1. Add basic headers in blink. 2. Add the necessary apis in chromium. 3. Start using this in WebglRenderingContxt.cpp. This patch represents step-2 in this process. BUG=412440 Committed: https://crrev.com/90f19fbfc25603d942ee4fe525cde30e5e28fbbb Cr-Commit-Position: refs/heads/master@{#302390}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Removed changes in public files. #

Patch Set 4 : Dnt alter public api, created new api. #

Total comments: 4

Patch Set 5 : Move the main logic to argument with glinfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/renderer/renderer_blink_platform_impl.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
sivag
sievers, piman ptal.. connecting blink patch @https://codereview.chromium.org/640293002/
6 years, 2 months ago (2014-10-10 14:16:38 UTC) #2
no sievers
+kbr
6 years, 2 months ago (2014-10-10 19:00:39 UTC) #4
piman
https://codereview.chromium.org/645613002/diff/20001/content/renderer/renderer_blink_platform_impl.cc File content/renderer/renderer_blink_platform_impl.cc (right): https://codereview.chromium.org/645613002/diff/20001/content/renderer/renderer_blink_platform_impl.cc#newcode932 content/renderer/renderer_blink_platform_impl.cc:932: blink::WebGLInfo glInfo; nit: gl_info https://codereview.chromium.org/645613002/diff/20001/content/renderer/renderer_blink_platform_impl.cc#newcode940 content/renderer/renderer_blink_platform_impl.cc:940: blink::WebGLInfo& glInfo) { ...
6 years, 2 months ago (2014-10-10 20:25:00 UTC) #5
Ken Russell (switch to Gerrit)
Please see your Blink CL for comment about avoiding even temporarily breaking the overrides of ...
6 years, 2 months ago (2014-10-10 20:49:00 UTC) #6
sivag
ptal.. https://codereview.chromium.org/645613002/diff/20001/content/renderer/renderer_blink_platform_impl.cc File content/renderer/renderer_blink_platform_impl.cc (right): https://codereview.chromium.org/645613002/diff/20001/content/renderer/renderer_blink_platform_impl.cc#newcode932 content/renderer/renderer_blink_platform_impl.cc:932: blink::WebGLInfo glInfo; On 2014/10/10 20:25:00, piman (Very slow ...
6 years, 1 month ago (2014-10-27 13:34:52 UTC) #7
piman
https://codereview.chromium.org/645613002/diff/140001/content/renderer/renderer_blink_platform_impl.cc File content/renderer/renderer_blink_platform_impl.cc (right): https://codereview.chromium.org/645613002/diff/140001/content/renderer/renderer_blink_platform_impl.cc#newcode932 content/renderer/renderer_blink_platform_impl.cc:932: blink::WebGLInfo gl_info; Why create a WebGLInfo if we're going ...
6 years, 1 month ago (2014-10-27 19:43:47 UTC) #8
sivag
ptal.. https://codereview.chromium.org/645613002/diff/140001/content/renderer/renderer_blink_platform_impl.cc File content/renderer/renderer_blink_platform_impl.cc (right): https://codereview.chromium.org/645613002/diff/140001/content/renderer/renderer_blink_platform_impl.cc#newcode932 content/renderer/renderer_blink_platform_impl.cc:932: blink::WebGLInfo gl_info; On 2014/10/27 19:43:47, piman (Very slow ...
6 years, 1 month ago (2014-10-28 15:29:00 UTC) #9
piman
lgtm
6 years, 1 month ago (2014-10-28 19:12:17 UTC) #10
Ken Russell (switch to Gerrit)
LGTM too FWIW.
6 years, 1 month ago (2014-10-29 02:13:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645613002/160001
6 years, 1 month ago (2014-10-29 03:21:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/29191)
6 years, 1 month ago (2014-10-29 03:32:15 UTC) #15
Ken Russell (switch to Gerrit)
On 2014/10/29 03:32:15, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-10-29 18:06:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645613002/160001
6 years, 1 month ago (2014-10-30 06:37:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645613002/160001
6 years, 1 month ago (2014-10-30 06:42:15 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/29730)
6 years, 1 month ago (2014-10-30 06:52:29 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645613002/160001
6 years, 1 month ago (2014-11-01 17:17:11 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:160001)
6 years, 1 month ago (2014-11-01 18:15:32 UTC) #28
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 18:16:16 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/90f19fbfc25603d942ee4fe525cde30e5e28fbbb
Cr-Commit-Position: refs/heads/master@{#302390}

Powered by Google App Engine
This is Rietveld 408576698