[WebGL-chromium] Return meaningful information in WebGL context creation error message

content/renderer/renderer_blink_platform_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_blink_platform_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 911 matching lines @@
   content::RenderThread::Get()->Send(
       new ViewHostMsg_GetProcessMemorySizes(private_bytes, shared_bytes));
   return true;
 }
 
 //------------------------------------------------------------------------------
 
 blink::WebGraphicsContext3D*
 RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(
     const blink::WebGraphicsContext3D::Attributes& attributes) {
-  return createOffscreenGraphicsContext3D(attributes, NULL);
+  blink::WebGLInfo gl_info;

[piman, 2014/10/27 19:43:47]

Why create a WebGLInfo if we're going to discard it?

[sivag, 2014/10/28 15:29:00]

Done. Sorry i missed this.

+  return createOffscreenGraphicsContext3D(attributes, NULL, &gl_info);
 }
 
 blink::WebGraphicsContext3D*
+RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(
+    const blink::WebGraphicsContext3D::Attributes& attributes,
+    blink::WebGraphicsContext3D* share_context,
+    blink::WebGLInfo* gl_info) {
+
+  RenderThreadImpl* render_thread = RenderThreadImpl::current();
+  if (render_thread && gl_info) {
+    GpuChannelHost* gpu_channel_host = render_thread->GetGpuChannel();

[piman, 2014/10/27 19:43:47]

This could be NULL, or a different channel than the one that was created/used
when creating the context (l.979), e.g. on the first creation or after a GPU
process loss. It could lead to inconsistent data.

How about: moving this code after l.981 in the other overload (passing gl_info
to that one and making this one a trivial wrapper).

[sivag, 2014/10/28 15:29:00]

Done.

+    if (gpu_channel_host) {
+      const gpu::GPUInfo& gpu_info = gpu_channel_host->gpu_info();
+      gl_info->vendorInfo.assign(
+          blink::WebString::fromUTF8(gpu_info.gl_vendor));
+      gl_info->rendererInfo.assign(
+          blink::WebString::fromUTF8(gpu_info.gl_renderer));
+      gl_info->driverVersion.assign(
+          blink::WebString::fromUTF8(gpu_info.gl_version));
+    }
+  }
+
+  return createOffscreenGraphicsContext3D(attributes, share_context);
+}
+
+blink::WebGraphicsContext3D*
 RendererBlinkPlatformImpl::createOffscreenGraphicsContext3D(
     const blink::WebGraphicsContext3D::Attributes& attributes,
     blink::WebGraphicsContext3D* share_context) {
   if (!RenderThreadImpl::current())
     return NULL;
 
 #if defined(OS_ANDROID)
   if (SynchronousCompositorFactory* factory =
       SynchronousCompositorFactory::GetInstance()) {
     scoped_ptr<webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl>
@@ skipping 225 matching lines @@
 void RendererBlinkPlatformImpl::MockBatteryStatusChangedForTesting(
     const blink::WebBatteryStatus& status) {
   PlatformEventObserverBase* observer =
       platform_event_observers_.Lookup(blink::WebPlatformEventBattery);
   if (!observer)
     return;
   observer->SendFakeDataForTesting((void*)&status);
 }
 
 }  // namespace content