|
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG= 417463
R=flackr@chromium.org
Committed: https://crrev.com/28401c280ebf802265ef7f387a0ecfe784551e16
Cr-Commit-Position: refs/heads/master@{#301541}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+427 lines, -515 lines) |
Patch |
 |
M |
ash/wm/always_on_top_controller.h
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/wm/app_list_controller.h
|
View
|
|
2 chunks |
+17 lines, -17 lines |
0 comments
|
Download
|
 |
M |
ash/wm/app_list_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/ash_focus_rules.h
|
View
|
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
ash/wm/ash_native_cursor_manager.h
|
View
|
|
2 chunks |
+10 lines, -14 lines |
0 comments
|
Download
|
 |
M |
ash/wm/ash_native_cursor_manager_interactive_uitest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/ash_native_cursor_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/cursor_manager_chromeos.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/wm/default_state.h
|
View
|
|
1 chunk |
+6 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/wm/default_window_resizer.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/dock/docked_window_layout_manager.h
|
View
|
|
3 chunks |
+25 lines, -29 lines |
0 comments
|
Download
|
 |
M |
ash/wm/dock/docked_window_layout_manager.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/wm/dock/docked_window_layout_manager_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/dock/docked_window_resizer.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/dock/docked_window_resizer_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/drag_window_resizer.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/event_client_impl.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/gestures/long_press_affordance_handler.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/gestures/long_press_affordance_handler.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/gestures/overview_gesture_handler_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/gestures/tray_gesture_handler.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/immersive_fullscreen_controller.h
|
View
|
|
2 chunks |
+18 lines, -19 lines |
0 comments
|
Download
|
 |
M |
ash/wm/immersive_fullscreen_controller.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/immersive_fullscreen_controller_unittest.cc
|
View
|
|
4 chunks |
+10 lines, -12 lines |
0 comments
|
Download
|
 |
M |
ash/wm/lock_layout_manager.h
|
View
|
|
1 chunk |
+20 lines, -20 lines |
0 comments
|
Download
|
 |
M |
ash/wm/lock_layout_manager_unittest.cc
|
View
|
|
3 chunks |
+8 lines, -18 lines |
0 comments
|
Download
|
 |
M |
ash/wm/lock_state_controller.h
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/wm/lock_state_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/lock_window_state.h
|
View
|
|
1 chunk |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/wm/mru_window_tracker.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/mru_window_tracker_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/overlay_event_filter.h
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/wm/partial_screenshot_view.h
|
View
|
|
2 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
ash/wm/partial_screenshot_view.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/wm/partial_screenshot_view_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/power_button_controller.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/resize_handle_window_targeter.h
|
View
|
|
1 chunk |
+8 lines, -11 lines |
0 comments
|
Download
|
 |
M |
ash/wm/resize_shadow_and_cursor_unittest.cc
|
View
|
|
2 chunks |
+7 lines, -13 lines |
0 comments
|
Download
|
 |
M |
ash/wm/resize_shadow_controller.h
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
ash/wm/root_window_layout_manager.h
|
View
|
|
1 chunk |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
ash/wm/screen_dimmer.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/screen_dimmer_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/session_state_animator_impl.h
|
View
|
|
1 chunk |
+12 lines, -14 lines |
0 comments
|
Download
|
 |
M |
ash/wm/session_state_animator_impl.cc
|
View
|
|
2 chunks |
+12 lines, -20 lines |
0 comments
|
Download
|
 |
M |
ash/wm/stacking_controller.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/stacking_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/status_area_layout_manager.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_background_controller.h
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_gesture_event_filter.h
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_gesture_event_filter_unittest.cc
|
View
|
|
6 chunks |
+22 lines, -29 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_modal_container_event_filter.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_modal_container_layout_manager.h
|
View
|
|
1 chunk |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
ash/wm/system_modal_container_layout_manager_unittest.cc
|
View
|
|
7 chunks |
+10 lines, -16 lines |
0 comments
|
Download
|
 |
M |
ash/wm/toplevel_window_event_handler.h
|
View
|
|
1 chunk |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/wm/toplevel_window_event_handler.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/toplevel_window_event_handler_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/wm/video_detector.h
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
ash/wm/video_detector_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/virtual_keyboard_container_layout_manager.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_animations.cc
|
View
|
|
1 chunk |
+11 lines, -18 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_animations_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_cycle_controller.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_cycle_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_cycle_list.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_cycle_list.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_manager_unittest.cc
|
View
|
|
6 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_modality_controller_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_positioner_unittest.cc
|
View
|
|
1 chunk |
+7 lines, -14 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_state.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_state.cc
|
View
|
|
1 chunk |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
ash/wm/window_state_unittest.cc
|
View
|
|
1 chunk |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
ash/wm/wm_event.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/wm/workspace_controller_unittest.cc
|
View
|
|
4 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|