Issue 645513006: Remove beforeunload events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645513006: Remove beforeunload events. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -235 lines)			Patch
M	sky/engine/bindings/core/v8/V8AbstractEventListener.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/core.gni	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/Document.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	sky/engine/core/events/BeforeUnloadEvent.h	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	sky/engine/core/events/BeforeUnloadEvent.cpp	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	sky/engine/core/events/BeforeUnloadEvent.idl	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	sky/engine/core/events/Event.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/events/Event.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/events/EventTarget.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	sky/engine/core/events/EventTypeNames.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/frame/DOMWindowEventHandlers.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	5 chunks	+0 lines, -57 lines	0 comments	Download
M	sky/engine/core/frame/UseCounter.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/frame/WindowEventHandlers.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

esprehn

6 years, 1 month ago (2014-10-23 21:08:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d3e147ad014531903ec5964c79b96474726ceab3.