Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: sky/engine/bindings/core/v8/V8AbstractEventListener.cpp

Issue 645513006: Remove beforeunload events. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8AbstractEventListener.cpp
diff --git a/sky/engine/bindings/core/v8/V8AbstractEventListener.cpp b/sky/engine/bindings/core/v8/V8AbstractEventListener.cpp
index e023575972d9ad133c5f9297647a47f2092534bd..2d862a0985d700fc209de6c0f705640b7abade69 100644
--- a/sky/engine/bindings/core/v8/V8AbstractEventListener.cpp
+++ b/sky/engine/bindings/core/v8/V8AbstractEventListener.cpp
@@ -37,7 +37,6 @@
#include "bindings/core/v8/V8EventTarget.h"
#include "bindings/core/v8/V8HiddenValue.h"
#include "core/dom/Document.h"
-#include "core/events/BeforeUnloadEvent.h"
#include "core/events/Event.h"
#include "core/inspector/InspectorCounters.h"
@@ -141,11 +140,6 @@ void V8AbstractEventListener::invokeEventHandler(Event* event, v8::Local<v8::Val
if (returnValue.IsEmpty())
return;
- if (m_isAttribute && !returnValue->IsNull() && !returnValue->IsUndefined() && event->isBeforeUnloadEvent()) {
- TOSTRING_VOID(V8StringResource<>, stringReturnValue, returnValue);
- toBeforeUnloadEvent(event)->setReturnValue(stringReturnValue);
- }
-
if (m_isAttribute && shouldPreventDefault(returnValue))
event->preventDefault();
}
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698