Git footer fix for v8

git_footers.py

Index: git_footers.py
diff --git a/git_footers.py b/git_footers.py
index fe72e18a9f832da4d0b5a774bfd6e1d5c2fee243..1358aff229f276a4d75feb325500e092f8604348 100755
--- a/git_footers.py
+++ b/git_footers.py
@@ -81,11 +81,22 @@ def get_position(footers):
   if svn_commit:
     match = GIT_SVN_ID_PATTERN.match(svn_commit)
     assert match, 'Invalid git-svn-id value: %s' % svn_commit
+    # V8 has different semantics than Chromium.
+    if re.match(r'.*https?://v8\.googlecode\.com/svn/trunk',
+                match.group(1)):
+      return ('refs/heads/candidates', match.group(2))
+    if re.match(r'.*https?://v8\.googlecode\.com/svn/branches/bleeding_edge',
+                match.group(1)):
+      return ('refs/heads/master', match.group(2))
+
     # Assume that any trunk svn revision will match the commit-position
     # semantics.
     if re.match('.*/trunk.*$', match.group(1)):
       return ('refs/heads/master', match.group(2))
 
+    if re.match('.*/bleeding_edge.*$', match.group(1)):

[Michael Achenbach, 2014/10/11 07:28:02]

What is this for? When would that match? What does it mean to return
refs/heads/?

[agable, 2014/10/13 08:37:15]

Agree, not sure what this is for. The stanzas up above look good, though.

[hinoka, 2014/10/13 17:26:07]

My bad, this wasn't supposed to be in here.

+      return ('refs/heads/', match.group(2))
+
     # But for now only support faking branch-heads for chrome.
     branch_match = re.match('.*/chrome/branches/([\w/-]+)/src$', match.group(1))
     if branch_match: