Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 645153002: WebView Guest should use ZOOM_MODE_ISOLATED. (Closed)

Created:
6 years, 2 months ago by wjmaclean
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, sergeygs
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebView Guest should use ZOOM_MODE_ISOLATED. In order that changes to zoom levels in a WebView Guest don't affect the embedder, set the WebView Guest's WebContents to use ZOOM_MODE_ISOLATED. BUG=418605 Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1 Cr-Commit-Position: refs/heads/master@{#299493}

Patch Set 1 #

Patch Set 2 : Rebased to master@299480 for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Fady Samuel
lgtm but it would be nice to get a test (in a separate CL if ...
6 years, 2 months ago (2014-10-10 21:03:40 UTC) #2
wjmaclean
On 2014/10/10 21:03:40, Fady Samuel wrote: > lgtm but it would be nice to get ...
6 years, 2 months ago (2014-10-14 15:13:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645153002/100001
6 years, 2 months ago (2014-10-14 15:20:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/68205)
6 years, 2 months ago (2014-10-14 15:58:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645153002/100001
6 years, 2 months ago (2014-10-14 16:13:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:100001)
6 years, 2 months ago (2014-10-14 16:33:43 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1 Cr-Commit-Position: refs/heads/master@{#299493}
6 years, 2 months ago (2014-10-14 16:34:34 UTC) #11
wjmaclean
6 years, 1 month ago (2014-10-31 21:38:21 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:100001) has been created in
https://codereview.chromium.org/690373002/ by wjmaclean@chromium.org.

The reason for reverting is: This CL seems to be at the root of several other
issues, including https://code.google.com/p/chromium/issues/detail?id=429004.

In particular, it seems to be allowing re-entrancy into ZoomController that was
unexpected due to the timing with which OnGuestReady() is called..

Powered by Google App Engine
This is Rietveld 408576698