chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc - Issue 645153002: WebView Guest should use ZOOM_MODE_ISOLATED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 645153002: WebView Guest should use ZOOM_MODE_ISOLATED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to master@299480 for landing. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

index 2bc3e42d6675d828fa8057294435e4631e6b4fae..2a9680964558c9cae040026b761e66c3bd32861c 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

@@ -135,6 +135,13 @@ void ChromeWebViewGuestDelegate::OnDocumentLoadedInFrame(

InjectChromeVoxIfNeeded(render_frame_host->GetRenderViewHost());

}

+void ChromeWebViewGuestDelegate::OnGuestReady() {

+ ZoomController* zoom_controller =

+ ZoomController::FromWebContents(guest_web_contents());

+ DCHECK(zoom_controller);

+ zoom_controller->SetZoomMode(ZoomController::ZOOM_MODE_ISOLATED);

void ChromeWebViewGuestDelegate::OnGuestDestroyed() {

// Clean up custom context menu items for this guest.

extensions::MenuManager* menu_manager = extensions::MenuManager::Get(