Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 645123004: Fix WeakPtrFactory member placement in ipc (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member placement Changing in the intialization order of WeakPtrFactory in src/ipc module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/755aaca0859cf9db13fb17d99e987ade0553af6a Cr-Commit-Position: refs/heads/master@{#299660}

Patch Set 1 #

Patch Set 2 : MOdified changes #

Patch Set 3 : Fixed build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ipc/mojo/ipc_channel_mojo_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-11 08:59:56 UTC) #2
dmichael (off chromium)
Looks OK to me, but I'm not an OWNER here. +morrita
6 years, 2 months ago (2014-10-14 22:22:09 UTC) #4
Hajime Morrita
lgtm. Thanks for taking this!
6 years, 2 months ago (2014-10-14 22:28:02 UTC) #5
anujsharma
On 2014/10/14 22:22:09, dmichael wrote: > Looks OK to me, but I'm not an OWNER ...
6 years, 2 months ago (2014-10-15 02:43:12 UTC) #6
anujsharma
On 2014/10/14 22:28:02, morrita wrote: > lgtm. Thanks for taking this! Thanks morrita for lgtm.
6 years, 2 months ago (2014-10-15 02:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645123004/30001
6 years, 2 months ago (2014-10-15 02:44:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/79176) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/24339) linux_chromium_gn_dbg ...
6 years, 2 months ago (2014-10-15 02:58:36 UTC) #11
anujsharma
On 2014/10/15 02:58:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-15 06:13:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645123004/80001
6 years, 2 months ago (2014-10-15 06:14:05 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 2 months ago (2014-10-15 07:20:13 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 07:21:02 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/755aaca0859cf9db13fb17d99e987ade0553af6a
Cr-Commit-Position: refs/heads/master@{#299660}

Powered by Google App Engine
This is Rietveld 408576698