Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: ipc/mojo/ipc_channel_mojo_host.cc

Issue 645123004: Fix WeakPtrFactory member placement in ipc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed build issue Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_host.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_channel_mojo_host.cc
diff --git a/ipc/mojo/ipc_channel_mojo_host.cc b/ipc/mojo/ipc_channel_mojo_host.cc
index efe2a2cedb79a50d05df0b1d940538df66ca5164..6f9075ae233c4767c9fec1b5bb53a5732615ec6c 100644
--- a/ipc/mojo/ipc_channel_mojo_host.cc
+++ b/ipc/mojo/ipc_channel_mojo_host.cc
@@ -31,8 +31,8 @@ class ChannelMojoHost::ChannelDelegate : public ChannelMojo::Delegate {
private:
scoped_refptr<base::TaskRunner> io_task_runner_;
- base::WeakPtrFactory<ChannelDelegate> weak_factory_;
base::WeakPtr<ChannelMojo> channel_;
+ base::WeakPtrFactory<ChannelDelegate> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ChannelDelegate);
};
@@ -84,9 +84,9 @@ void ChannelMojoHost::ChannelDelegate::DeleteThisSoon() {
//
ChannelMojoHost::ChannelMojoHost(scoped_refptr<base::TaskRunner> io_task_runner)
- : weak_factory_(this),
- io_task_runner_(io_task_runner),
- channel_delegate_(new ChannelDelegate(io_task_runner)) {
+ : io_task_runner_(io_task_runner),
+ channel_delegate_(new ChannelDelegate(io_task_runner)),
+ weak_factory_(this) {
}
ChannelMojoHost::~ChannelMojoHost() {
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698