Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 645043003: Cleanup: Prevent usage of various extension headers when extensions support is not compiled in. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, asanka, tim+watch_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, pvalenzuela+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Prevent usage of various extension headers when extensions support is not compiled in. Committed: https://crrev.com/44b9ce2b61788e5e9b088e28c48c7d171847b2c1 Cr-Commit-Position: refs/heads/master@{#300053}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : update comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -20 lines) Patch
M chrome/browser/autocomplete/shortcuts_backend.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/extensions_activity_monitor.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extensions_activity_monitor.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 6 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 2 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/extension_registry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/notification_types.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Lei Zhang
6 years, 2 months ago (2014-10-16 18:49:24 UTC) #3
Yoyo Zhou
LGTM https://codereview.chromium.org/645043003/diff/20001/extensions/browser/notification_types.h File extensions/browser/notification_types.h (right): https://codereview.chromium.org/645043003/diff/20001/extensions/browser/notification_types.h#newcode20 extensions/browser/notification_types.h:20: // WARNING: Do not change this. This is ...
6 years, 2 months ago (2014-10-16 22:18:52 UTC) #4
Lei Zhang
https://codereview.chromium.org/645043003/diff/20001/extensions/browser/notification_types.h File extensions/browser/notification_types.h (right): https://codereview.chromium.org/645043003/diff/20001/extensions/browser/notification_types.h#newcode20 extensions/browser/notification_types.h:20: // WARNING: Do not change this. On 2014/10/16 22:18:52, ...
6 years, 2 months ago (2014-10-17 02:05:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645043003/60001
6 years, 2 months ago (2014-10-17 02:09:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-17 03:19:42 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 03:20:28 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/44b9ce2b61788e5e9b088e28c48c7d171847b2c1
Cr-Commit-Position: refs/heads/master@{#300053}

Powered by Google App Engine
This is Rietveld 408576698