Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: extensions/browser/notification_types.h

Issue 645043003: Cleanup: Prevent usage of various extension headers when extensions support is not compiled in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/extension_system.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_ 5 #ifndef EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_
6 #define EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_ 6 #define EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_
7 7
8 #include "content/public/browser/notification_types.h" 8 #include "content/public/browser/notification_types.h"
9 9
10 #if !defined(ENABLE_EXTENSIONS)
11 #error "Extensions must be enabled"
12 #endif
13
10 namespace extensions { 14 namespace extensions {
11 15
12 // Only notifications fired by the extensions module should be here. The 16 // Only notifications fired by the extensions module should be here. The
13 // extensions module should not listen to notifications fired by the 17 // extensions module should not listen to notifications fired by the
14 // embedder. 18 // embedder.
15 enum NotificationType { 19 enum NotificationType {
20 // WARNING: Do not change this.
Yoyo Zhou 2014/10/16 22:18:52 This is unnecessarily ominous. Why not point to th
Lei Zhang 2014/10/17 02:05:56 Sure. Done.
16 NOTIFICATION_EXTENSIONS_START = content::NOTIFICATION_CONTENT_END, 21 NOTIFICATION_EXTENSIONS_START = content::NOTIFICATION_CONTENT_END,
17 22
18 // Sent when a CrxInstaller finishes. Source is the CrxInstaller that 23 // Sent when a CrxInstaller finishes. Source is the CrxInstaller that
19 // finished. The details are the extension which was installed. 24 // finished. The details are the extension which was installed.
20 NOTIFICATION_CRX_INSTALLER_DONE = NOTIFICATION_EXTENSIONS_START, 25 NOTIFICATION_CRX_INSTALLER_DONE = NOTIFICATION_EXTENSIONS_START,
21 26
22 // Sent when the known installed extensions have all been loaded. In 27 // Sent when the known installed extensions have all been loaded. In
23 // testing scenarios this can happen multiple times if extensions are 28 // testing scenarios this can happen multiple times if extensions are
24 // unloaded and reloaded. The source is a BrowserContext*. 29 // unloaded and reloaded. The source is a BrowserContext*.
25 // 30 //
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 208
204 // Sent when there are new user scripts available. The details are a 209 // Sent when there are new user scripts available. The details are a
205 // pointer to SharedMemory containing the new scripts. 210 // pointer to SharedMemory containing the new scripts.
206 NOTIFICATION_USER_SCRIPTS_UPDATED, 211 NOTIFICATION_USER_SCRIPTS_UPDATED,
207 NOTIFICATION_EXTENSIONS_END 212 NOTIFICATION_EXTENSIONS_END
208 }; 213 };
209 214
210 } // namespace extensions 215 } // namespace extensions
211 216
212 #endif // EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_ 217 #endif // EXTENSIONS_BROWSER_NOTIFICATION_TYPES_H_
OLDNEW
« no previous file with comments | « extensions/browser/extension_system.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698