Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644963004: Some more virtual/override updates. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Some more virtual/override updates. (These are mostly fixes to things that derive from testing::Test, which are missed for some reason.) R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/153dd219f81c335977f585fca933f1a59e3f81e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M mojo/application_manager/application_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/apptest/example_apptest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/equals_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/run_loop_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/clipboard/clipboard_standalone_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/udp_socket_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/child_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_application_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/incoming_connection_listener_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/shell_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 21:27:09 UTC) #1
sky
Rubber stamp LGTM
6 years, 2 months ago (2014-10-21 21:38:35 UTC) #2
viettrungluu
6 years, 2 months ago (2014-10-21 21:41:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
153dd219f81c335977f585fca933f1a59e3f81e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698