mojo/shell/external_application_listener_unittest.cc - Issue 644963004: Some more virtual/override updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/external_application_listener_unittest.cc

Issue 644963004: Some more virtual/override updates. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/external_application_listener_unittest.cc

diff --git a/mojo/shell/external_application_listener_unittest.cc b/mojo/shell/external_application_listener_unittest.cc

index 2fc5511de2c415dbe3ec1f114bec537b01f2269d..7c1465b28df1ffc2f4ffda9808ca6d1b89eeb462 100644

--- a/mojo/shell/external_application_listener_unittest.cc

+++ b/mojo/shell/external_application_listener_unittest.cc

@@ -28,9 +28,9 @@ namespace shell {

class ExternalApplicationListenerTest : public testing::Test {

public:

ExternalApplicationListenerTest() : io_thread_("io thread") {}

- virtual ~ExternalApplicationListenerTest() {}

+ ~ExternalApplicationListenerTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

base::Thread::Options options;

options.message_loop_type = base::MessageLoop::TYPE_IO;

io_thread_.StartWithOptions(options);