Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 644963002: Content Shell: Drop an unused method. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Drop an unused method. ShellDevToolsFrontend::RenderProcessGone's functionality is now entirely contained in LayoutTestDevToolsFrontend; I should have removed this definition in https://codereview.chromium.org/644723002. BUG=420994 Committed: https://crrev.com/781ceef3f7da81f3b9567d8b173172742c6b8140 Cr-Commit-Position: refs/heads/master@{#299081}

Patch Set 1 #

Patch Set 2 : h #

Patch Set 3 : Oops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/shell/browser/shell_devtools_frontend.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
WDYT, Peter?
6 years, 2 months ago (2014-10-10 08:21:53 UTC) #2
pfeldman
lgtm.
6 years, 2 months ago (2014-10-10 08:35:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644963002/140001
6 years, 2 months ago (2014-10-10 08:37:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:140001)
6 years, 2 months ago (2014-10-10 09:04:23 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 09:05:08 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/781ceef3f7da81f3b9567d8b173172742c6b8140
Cr-Commit-Position: refs/heads/master@{#299081}

Powered by Google App Engine
This is Rietveld 408576698