Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 644723002: Content Shell: Introduce LayoutTestDevToolsFrontend. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestDevToolsFrontend. This patch splits out the DRT-specific bits of ShellDevToolsFrontend and moves them to a new class, which is only instantiated if the flag is set. BUG=420994 Committed: https://crrev.com/30d20d59838a6d83ec80852e044e4ac1916f51e4 Cr-Commit-Position: refs/heads/master@{#298865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -51 lines) Patch
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 chunk +40 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M content/shell/browser/shell.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 3 chunks +3 lines, -7 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 2 chunks +4 lines, -41 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Mike West
WDYT?
6 years, 2 months ago (2014-10-09 13:14:48 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-09 13:16:13 UTC) #3
Mike West
Peter, since you're interested, want to review this patch?
6 years, 2 months ago (2014-10-09 13:16:24 UTC) #5
Mike West
On 2014/10/09 13:16:24, Mike West wrote: > Peter, since you're interested, want to review this ...
6 years, 2 months ago (2014-10-09 13:19:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644723002/1
6 years, 2 months ago (2014-10-09 13:19:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as bf7e0bfa21e3ed52cb874074b114bfe2f4efbe32
6 years, 2 months ago (2014-10-09 13:33:24 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:34:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30d20d59838a6d83ec80852e044e4ac1916f51e4
Cr-Commit-Position: refs/heads/master@{#298865}

Powered by Google App Engine
This is Rietveld 408576698