Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 644813006: Revert of WebRTC: Enable bot_update for standalone recipe. (Closed)

Created:
6 years, 2 months ago by kjellander_chromium
Modified:
6 years, 2 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Revert of WebRTC: Enable bot_update for standalone recipe. (patchset #5 id:820001 of https://codereview.chromium.org/472963003/) Reason for revert: Turns out our Mac trybots are using a too old version of Git (git/1.7.4.1) the patch step fails like this: Applying the patch. Failed to apply patch for codereview.settings: While running git apply --index -3 -p1 --verbose; error: unknown switch `3' Original issue's description: > WebRTC: Enable bot_update for standalone recipe. > > Depends on https://codereview.chromium.org/627493002/ being > landed first. > > BUG=webrtc:3534, 419516 > TEST=Passing build with https://codereview.chromium.org/627493002/ applied: > scripts/tools/run_recipe.py webrtc/standalone buildername="Linux64 Debug" mastername=client.webrtc slavename=x revision='"7417"' use_mirror=True > Also tried a trybot: > scripts/tools/run_recipe.py webrtc/standalone buildername="linux" mastername=tryserver.webrtc slavename=x revision='"7417"' patchset=1 issue=12659005 rietveld=https://webrtc-codereview.appspot.com use_mirror=True root=src > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292403 TBR=hinoka@chromium.org,hinoka@google.com NOTREECHECKS=true NOTRY=true BUG=webrtc:3534, 419516 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -62 lines) Patch
M scripts/slave/bot_update.py View 2 chunks +3 lines, -6 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux.json View 1 chunk +54 lines, -14 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_legacy_svn_patch.json View 1 chunk +54 lines, -14 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac.json View 1 chunk +54 lines, -14 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win.json View 1 chunk +54 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kjellander_chromium
Created Revert of WebRTC: Enable bot_update for standalone recipe.
6 years, 2 months ago (2014-10-10 13:11:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644813006/1
6 years, 2 months ago (2014-10-10 13:12:27 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:13:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292404

Powered by Google App Engine
This is Rietveld 408576698