Source/core/css/MediaValuesCached.cpp - Issue 644813005: Floating point MQs should not match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaValuesCached.cpp

Issue 644813005: Floating point MQs should not match. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaValuesCached.cpp

diff --git a/Source/core/css/MediaValuesCached.cpp b/Source/core/css/MediaValuesCached.cpp

index 8f0816a52bf22e4d83a0d64e88a6324a5d014f78..0cf7d56eaa3f3f7833af9526060c3b6cb2572630 100644

--- a/Source/core/css/MediaValuesCached.cpp

+++ b/Source/core/css/MediaValuesCached.cpp

@@ -81,7 +81,7 @@ bool MediaValuesCached::computeLength(double value, CSSPrimitiveValue::UnitType

return MediaValues::computeLength(value, type, m_data.defaultFontSize, m_data.viewportWidth, m_data.viewportHeight, result);

}

-bool MediaValuesCached::computeLength(double value, CSSPrimitiveValue::UnitType type, double& result) const

+bool MediaValuesCached::computeLength(double value, CSSPrimitiveValue::UnitType type, float& result) const

{

return MediaValues::computeLength(value, type, m_data.defaultFontSize, m_data.viewportWidth, m_data.viewportHeight, result);

}