Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/css/MediaQueryEvaluatorTest.cpp

Issue 644813005: Floating point MQs should not match. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaValues.h » ('j') | Source/core/css/MediaValues.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryEvaluatorTest.cpp
diff --git a/Source/core/css/MediaQueryEvaluatorTest.cpp b/Source/core/css/MediaQueryEvaluatorTest.cpp
index f982909ebcdd6a8cf1c5baf3b393ed6ee0e9e56c..20b1094084d266ad1f6397bcb5e9bb6f50645d6b 100644
--- a/Source/core/css/MediaQueryEvaluatorTest.cpp
+++ b/Source/core/css/MediaQueryEvaluatorTest.cpp
@@ -63,6 +63,8 @@ TestCase viewportTestCases[] = {
{"(max-height: 500px)", 1},
{"(max-height: 499px)", 0},
{"(height: 500px)", 1},
+ {"(height: 500.1px)", 0},
+ {"(height: 499.9px)", 0},
rune 2014/10/10 09:01:46 Please add tests for the min/max ones too. max 499
{"(height: 501px)", 0},
{"screen and (min-width: 400px) and (max-width: 700px)", 1},
{0, 0} // Do not remove the terminator line.
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaValues.h » ('j') | Source/core/css/MediaValues.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698