Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 644813003: [Contextual Search] Passing HTTML status code to WebContentsObserverAndroid. (Closed)

Created:
6 years, 2 months ago by pedro (no code reviews)
Modified:
6 years, 2 months ago
Reviewers:
Donn Denman, Yaron, donnd
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Passing HTTML status code to WebContentsObserverAndroid. BUG=422077 Committed: https://crrev.com/c22a907a1899bf6e265c6afc747d127622812bc8 Cr-Commit-Position: refs/heads/master@{#299025}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M content/browser/android/web_contents_observer_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java View 1 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pedro (no code reviews)
Hey Donn. Please take a look at this change.
6 years, 2 months ago (2014-10-09 21:56:51 UTC) #2
donnd
LGTM except for one typo. https://codereview.chromium.org/644813003/diff/1/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/644813003/diff/1/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode58 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:58: * TODO(pedrosimonetti): Remove this ...
6 years, 2 months ago (2014-10-09 22:01:07 UTC) #4
pedro (no code reviews)
Hey Yaron, as we discussed offline, this is the change we need for Contextual Search. ...
6 years, 2 months ago (2014-10-09 22:12:54 UTC) #6
Yaron
lgtm
6 years, 2 months ago (2014-10-09 22:34:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644813003/90001
6 years, 2 months ago (2014-10-09 22:56:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:90001)
6 years, 2 months ago (2014-10-10 00:37:34 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:38:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c22a907a1899bf6e265c6afc747d127622812bc8
Cr-Commit-Position: refs/heads/master@{#299025}

Powered by Google App Engine
This is Rietveld 408576698