Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

Issue 644813003: [Contextual Search] Passing HTTML status code to WebContentsObserverAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing typo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/web_contents_observer_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
index 6237141ef2208402a763b2515d4c268122c93d5e..ed528f2449ea311e85775648f640d2bf48f600ef 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
@@ -55,18 +55,33 @@ public abstract class WebContentsObserverAndroid {
/**
* Called when the main frame of the page has committed.
+ * TODO(pedrosimonetti): Remove this method once downstream changes are landed.
* @param url The validated url for the page.
* @param baseUrl The validated base url for the page.
* @param isNavigationToDifferentPage Whether the main frame navigated to a different page.
* @param isFragmentNavigation Whether the main frame navigation did not cause changes to the
* document (for example scrolling to a named anchor or PopState).
*/
- @CalledByNative
public void didNavigateMainFrame(String url, String baseUrl,
boolean isNavigationToDifferentPage, boolean isFragmentNavigation) {
}
/**
+ * Called when the main frame of the page has committed.
+ * @param url The validated url for the page.
+ * @param baseUrl The validated base url for the page.
+ * @param isNavigationToDifferentPage Whether the main frame navigated to a different page.
+ * @param isFragmentNavigation Whether the main frame navigation did not cause changes to the
+ * document (for example scrolling to a named anchor or PopState).
+ * @param statusCode The HTTP status code of the navigation.
+ */
+ @CalledByNative
+ public void didNavigateMainFrame(String url, String baseUrl,
+ boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {
+ didNavigateMainFrame(url, baseUrl, isNavigationToDifferentPage, isFragmentNavigation);
+ }
+
+ /**
* Called when the page had painted something non-empty.
*/
@CalledByNative
« no previous file with comments | « content/browser/android/web_contents_observer_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698